From: Pasi Kallinen <paxed@alt.org>
Date: Wed, 13 Sep 2017 11:12:38 +0000 (+0300)
Subject: Fix more warnings
X-Git-Tag: NetHack-3.6.1_RC01~367
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=127f74bb2457f67ea790ef1940c5f373dcd2978a;p=nethack

Fix more warnings
---

diff --git a/src/files.c b/src/files.c
index 195346f32..cfeabfbd6 100644
--- a/src/files.c
+++ b/src/files.c
@@ -192,7 +192,7 @@ STATIC_DCL char *FDECL(make_lockname, (const char *, char *));
 #endif
 STATIC_DCL void FDECL(set_configfile_name, (const char *));
 STATIC_DCL FILE *FDECL(fopen_config_file, (const char *, int));
-STATIC_DCL int FDECL(get_uchars, (char *, char *, uchar *, BOOLEAN_P,
+STATIC_DCL int FDECL(get_uchars, (char *, uchar *, BOOLEAN_P,
                                   int, const char *));
 boolean FDECL(proc_wizkit_line, (char *));
 boolean FDECL(parse_config_line, (char *));
@@ -2055,8 +2055,7 @@ int src;
  *  location is unchanged.  Callers must handle zeros if modlist is FALSE.
  */
 STATIC_OVL int
-get_uchars(buf, bufp, list, modlist, size, name)
-char *buf;        /* read buffer, must be of size BUFSZ */
+get_uchars(bufp, list, modlist, size, name)
 char *bufp;       /* current pointer */
 uchar *list;      /* return list */
 boolean modlist;  /* TRUE: list is being modified in place */
@@ -2535,13 +2534,13 @@ char *origbuf;
 #endif /* SYSCF */
 
     } else if (match_varname(buf, "BOULDER", 3)) {
-        (void) get_uchars(buf, bufp, &iflags.bouldersym, TRUE, 1,
+        (void) get_uchars(bufp, &iflags.bouldersym, TRUE, 1,
                           "BOULDER");
     } else if (match_varname(buf, "MENUCOLOR", 9)) {
         if (!add_menu_coloring(bufp))
             retval = FALSE;
     } else if (match_varname(buf, "WARNINGS", 5)) {
-        (void) get_uchars(buf, bufp, translate, FALSE, WARNCOUNT,
+        (void) get_uchars(bufp, translate, FALSE, WARNCOUNT,
                           "WARNINGS");
         assign_warnings(translate);
     } else if (match_varname(buf, "SYMBOLS", 4)) {
@@ -2754,11 +2753,12 @@ const char *line;
 void config_error_add
 VA_DECL(const char *, str)
 {
-    VA_START(str);
-    VA_INIT(str, char *);
     char buf[BUFSZ];
     char lineno[QBUFSZ];
 
+    VA_START(str);
+    VA_INIT(str, char *);
+
     Vsprintf(buf, str, VA_ARGS);
 
     config_err_num_errors++;
@@ -2773,7 +2773,7 @@ VA_DECL(const char *, str)
     pline("%s %s%s.",
           config_err_secure ? "Error:" : " *",
           lineno,
-          (buf && buf[0]) ? buf : "Unknown error");
+          *buf ? buf : "Unknown error");
 
     VA_END();
 }