From: Bram Moolenaar Date: Sat, 10 Sep 2022 09:42:20 +0000 (+0100) Subject: patch 9.0.0433: Coverity warns for not checking allocation failure X-Git-Tag: v9.0.0433 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=12553ada3b1ceee0179527abc9980b8392fd6c7e;p=vim patch 9.0.0433: Coverity warns for not checking allocation failure Problem: Coverity warns for not checking allocation failure. Solution: Check that allocating a list or blob succeeded. --- diff --git a/src/eval.c b/src/eval.c index 989147381..d69abb017 100644 --- a/src/eval.c +++ b/src/eval.c @@ -1121,6 +1121,8 @@ get_lval( var2.v_type = VAR_UNKNOWN; while (*p == '[' || (*p == '.' && p[1] != '=' && p[1] != '.')) { + int r; + if (*p == '.' && lp->ll_tv->v_type != VAR_DICT) { if (!quiet) @@ -1136,12 +1138,14 @@ get_lval( return NULL; } - // a NULL list/blob works like an empty list/blob, allocate one now. + // A NULL list/blob works like an empty list/blob, allocate one now. if (lp->ll_tv->v_type == VAR_LIST && lp->ll_tv->vval.v_list == NULL) - rettv_list_alloc(lp->ll_tv); + r = rettv_list_alloc(lp->ll_tv); else if (lp->ll_tv->v_type == VAR_BLOB && lp->ll_tv->vval.v_blob == NULL) - rettv_blob_alloc(lp->ll_tv); + r = rettv_blob_alloc(lp->ll_tv); + if (r == FAIL) + return NULL; if (lp->ll_range) { diff --git a/src/version.c b/src/version.c index 3c7c9c82d..51478ad6e 100644 --- a/src/version.c +++ b/src/version.c @@ -703,6 +703,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ +/**/ + 433, /**/ 432, /**/