From: Jaromír Doleček <jdolecek@NetBSD.org>
Date: Sun, 17 Dec 2017 11:56:37 +0000 (+0100)
Subject: Fixed bug #75616
X-Git-Tag: php-7.2.2RC1~68
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=11eed9f3ba7429be467b54d8407cfbd6bd7e6f3a;p=php

Fixed bug #75616

PDO can be built shared on Darwin nowadays. There used to be issues
relating to symbol references between dynamically loaded shared
objects.
---

diff --git a/NEWS b/NEWS
index b054c19a6f..05a584b995 100644
--- a/NEWS
+++ b/NEWS
@@ -11,6 +11,10 @@ PHP                                                                        NEWS
     (Nikita, Laruence)
   . Fixed bug #75698 (Using @ crashes php7.2-fpm). (Nikita)
 
+- PDO:
+  . Fixed bug #75616 (PDO extension doesn't allow to be built shared on Darwin).
+    (jdolecek)
+
 - PDO MySQL:
   . Fixed bug #75615 (PDO Mysql module can't be built as module). (jdolecek)
 
diff --git a/ext/pdo/config.m4 b/ext/pdo/config.m4
index 786c70382a..8cbf21733d 100755
--- a/ext/pdo/config.m4
+++ b/ext/pdo/config.m4
@@ -37,20 +37,6 @@ if test "$PHP_PDO" != "no"; then
 
   PHP_PDO_PEAR_CHECK
 
-  if test "$ext_shared" = "yes" ; then
-    case $host_alias in
-      *darwin*)
-          AC_MSG_ERROR([
-Due to the way that loadable modules work on OSX/Darwin, you need to
-compile the PDO package statically into the PHP core.
-
-Please follow the instructions at: http://netevil.org/node.php?nid=202
-for more detail on this issue.
-          ])
-        ext_shared=no
-        ;;
-    esac
-  fi
   PHP_NEW_EXTENSION(pdo, pdo.c pdo_dbh.c pdo_stmt.c pdo_sql_parser.c pdo_sqlstate.c, $ext_shared)
   ifdef([PHP_ADD_EXTENSION_DEP],
   [