From: Tim Northover Date: Wed, 13 Apr 2016 17:08:51 +0000 (+0000) Subject: ARM: make Darwin's "-arch armv7em" default to hard-float. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=11b940607f9dab3090ae05f268c2815d9f60bf87;p=clang ARM: make Darwin's "-arch armv7em" default to hard-float. We've already paid the price for separate "armv7m" and "armv7em" slices (support in other tools), it's silly to make them identical other than the default CPU. rdar://23055688 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@266211 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index 74bfc6ebde..75424e8700 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -803,7 +803,12 @@ arm::FloatABI arm::getARMFloatABI(const ToolChain &TC, const ArgList &Args) { break; default: // Assume "soft", but warn the user we are guessing. - ABI = FloatABI::Soft; + if (Triple.isOSBinFormatMachO() && + Triple.getSubArch() == llvm::Triple::ARMSubArch_v7em) + ABI = FloatABI::Hard; + else + ABI = FloatABI::Soft; + if (Triple.getOS() != llvm::Triple::UnknownOS || !Triple.isOSBinFormatMachO()) D.Diag(diag::warn_drv_assuming_mfloat_abi_is) << "soft"; diff --git a/test/Driver/darwin-embedded.c b/test/Driver/darwin-embedded.c index 66b7bd9fa7..beb8b195c4 100644 --- a/test/Driver/darwin-embedded.c +++ b/test/Driver/darwin-embedded.c @@ -1,6 +1,6 @@ // RUN: %clang -target x86_64-apple-darwin -arch armv6m -resource-dir=%S/Inputs/resource_dir %s -### 2> %t // RUN: %clang -target x86_64-apple-darwin -arch armv7em -resource-dir=%S/Inputs/resource_dir %s -### 2>> %t -// RUN: %clang -target x86_64-apple-darwin -arch armv7em -mhard-float -resource-dir=%S/Inputs/resource_dir %s -### 2>> %t +// RUN: %clang -target x86_64-apple-darwin -arch armv7em -mfloat-abi=soft -resource-dir=%S/Inputs/resource_dir %s -### 2>> %t // RUN: %clang -target x86_64-apple-darwin -arch armv7m -fPIC -resource-dir=%S/Inputs/resource_dir %s -### 2>> %t // RUN: %clang -target x86_64-apple-darwin -arch armv7em -fPIC -mfloat-abi=hard -resource-dir=%S/Inputs/resource_dir %s -### 2>> %t @@ -17,17 +17,18 @@ // CHECK: "-mfloat-abi" "soft" // CHECK: libclang_rt.soft_static.a -// ARMv7em does, but defaults to soft +// ARMv7em does // CHECK-LABEL: Target: // CHECK-NOT: warning: unknown platform -// CHECK: "-mfloat-abi" "soft" -// CHECK: libclang_rt.soft_static.a +// CHECK: "-mfloat-abi" "hard" +// CHECK: libclang_rt.hard_static.a -// Which can be overridden +// but the ABI can be overridden // CHECK-LABEL: Target: // CHECK-NOT: warning: unknown platform -// CHECK: "-mfloat-abi" "hard" -// CHECK: libclang_rt.hard_static.a +// CHECK: "-target-feature" "+soft-float" +// CHECK: "-mfloat-abi" "soft" +// CHECK: libclang_rt.soft_static.a // ARMv7m has no float either // CHECK-LABEL: Target: