From: Ted Kremenek <kremenek@apple.com>
Date: Thu, 24 Sep 2009 00:44:26 +0000 (+0000)
Subject: Shorten the static analyzer diagnostic for 'use of garbage value'.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=112ba7e57e23c2310479fd6bb116d9570fc2b77d;p=clang

Shorten the static analyzer diagnostic for 'use of garbage value'.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@82672 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/GRExprEngineInternalChecks.cpp b/lib/Analysis/GRExprEngineInternalChecks.cpp
index 2eb5589117..cc1ec4b77e 100644
--- a/lib/Analysis/GRExprEngineInternalChecks.cpp
+++ b/lib/Analysis/GRExprEngineInternalChecks.cpp
@@ -235,9 +235,9 @@ public:
                 
         if (Ex) {
           OS << "The " << (isLeft ? "left" : "right")
-             << " operand of the '"
+             << " operand of '"
              << BinaryOperator::getOpcodeStr(B->getOpcode())
-             << "' expression is a garbage value";
+             << "' is a garbage value";
         }          
         else {
           // Neither operand was undefined, but the result is undefined.
diff --git a/test/Analysis/uninit-vals-ps-region.c b/test/Analysis/uninit-vals-ps-region.c
index 716b7c920f..1561f11c99 100644
--- a/test/Analysis/uninit-vals-ps-region.c
+++ b/test/Analysis/uninit-vals-ps-region.c
@@ -25,7 +25,7 @@ void test_uninit_pos() {
   struct TestUninit v2 = test_uninit_aux();
   int z;
   v1.y = z;
-  test_unit_aux2(v2.x + v1.y);  // expected-warning{{The right operand of the '+' expression is a garbage value}}
+  test_unit_aux2(v2.x + v1.y);  // expected-warning{{The right operand of '+' is a garbage value}}
 }
 void test_uninit_neg() {
   struct TestUninit v1 = { 0, 0 };
diff --git a/test/Analysis/uninit-vals-ps.c b/test/Analysis/uninit-vals-ps.c
index 32b4324a7d..759c7edbcc 100644
--- a/test/Analysis/uninit-vals-ps.c
+++ b/test/Analysis/uninit-vals-ps.c
@@ -22,7 +22,7 @@ int f2() {
   
   int x;
   
-  if (x+1)  // expected-warning{{The left operand of the '+' expression is a garbage value}}
+  if (x+1)  // expected-warning{{The left operand of '+' is a garbage value}}
     return 1;
     
   return 2;  
@@ -31,13 +31,13 @@ int f2() {
 int f2_b() {
   int x;
   
-  return ((1+x)+2+((x))) + 1 ? 1 : 2; // expected-warning{{The right operand of the '+' expression is a garbage value}}
+  return ((1+x)+2+((x))) + 1 ? 1 : 2; // expected-warning{{The right operand of '+' is a garbage value}}
 }
 
 int f3(void) {
   int i;
   int *p = &i;
-  if (*p > 0) // expected-warning{{The left operand of the '>' expression is a garbage value}}
+  if (*p > 0) // expected-warning{{The left operand of '>' is a garbage value}}
     return 0;
   else
     return 1;