From: Moritz Bunkus <mo@bunkus.online>
Date: Thu, 22 Sep 2022 12:58:22 +0000 (+0200)
Subject: KaxSemantic: re-enable KaxClusterPosition
X-Git-Tag: release-1.7.0~16
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=10f5f5104aabed888b09ebbf1f9203a983c4ec77;p=libmatroska

KaxSemantic: re-enable KaxClusterPosition

Existing tools use that element.

See https://github.com/ietf-wg-cellar/matroska-specification/pull/670
---

diff --git a/matroska/KaxSemantic.h b/matroska/KaxSemantic.h
index bc4cb80..625e9ed 100644
--- a/matroska/KaxSemantic.h
+++ b/matroska/KaxSemantic.h
@@ -125,8 +125,6 @@ public:
 };
 
 DECLARE_MKX_UINTEGER(KaxClusterPosition)
-public:
-  filepos_t RenderData(IOCallback & output, bool bForceRender, bool bSaveDefault);
 };
 
 DECLARE_MKX_UINTEGER(KaxClusterPrevSize)
diff --git a/src/KaxSemantic.cpp b/src/KaxSemantic.cpp
index 53ead4c..856bfc8 100644
--- a/src/KaxSemantic.cpp
+++ b/src/KaxSemantic.cpp
@@ -116,7 +116,7 @@ DEFINE_MKX_UNISTRING(KaxWritingApp, 0x5741, 2, KaxInfo, "WritingApp")
 DEFINE_START_SEMANTIC(KaxCluster)
 DEFINE_SEMANTIC_ITEM(true, true, KaxClusterTimecode)
 DEFINE_SEMANTIC_ITEM(false, true, KaxClusterSilentTracks) // not supported
-DEFINE_SEMANTIC_ITEM(false, true, KaxClusterPosition) // not supported
+DEFINE_SEMANTIC_ITEM(false, true, KaxClusterPosition)
 DEFINE_SEMANTIC_ITEM(false, true, KaxClusterPrevSize)
 DEFINE_SEMANTIC_ITEM(false, false, KaxSimpleBlock)
 DEFINE_SEMANTIC_ITEM(false, false, KaxBlockGroup)
@@ -767,11 +767,6 @@ filepos_t KaxClusterSilentTrackNumber::RenderData(IOCallback & /* output */, boo
   return 0;
 }
 
-filepos_t KaxClusterPosition::RenderData(IOCallback & /* output */, bool /* bForceRender */, bool /* bSaveDefault */) {
-  assert(false); // no you are not allowed to use this element !
-  return 0;
-}
-
 filepos_t KaxBlockVirtual::RenderData(IOCallback & /* output */, bool /* bForceRender */, bool /* bSaveDefault */) {
   assert(false); // no you are not allowed to use this element !
   return 0;