From: Richard Levitte <levitte@openssl.org>
Date: Mon, 23 Apr 2018 08:26:05 +0000 (+0200)
Subject: Fix late opening of output file
X-Git-Tag: OpenSSL_1_1_1-pre6~63
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=10b37541dc7f27b0ca74102970691ce4636cc0bd;p=openssl

Fix late opening of output file

For 'openssl dhparams', the output file was opened after calculations
were made, which is a waste of cycles and time if the output file
turns out not to be writable.

Fixes #3404

Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/6051)
---

diff --git a/apps/dhparam.c b/apps/dhparam.c
index 8a3a389155..44160fde2b 100644
--- a/apps/dhparam.c
+++ b/apps/dhparam.c
@@ -153,6 +153,11 @@ int dhparam_main(int argc, char **argv)
         goto end;
     }
 # endif
+
+    out = bio_open_default(outfile, 'w', outformat);
+    if (out == NULL)
+        goto end;
+
     /* DH parameters */
     if (num && !g)
         g = 2;
@@ -260,10 +265,6 @@ int dhparam_main(int argc, char **argv)
         /* dh != NULL */
     }
 
-    out = bio_open_default(outfile, 'w', outformat);
-    if (out == NULL)
-        goto end;
-
     if (text) {
         DHparams_print(out, dh);
     }