From: Bert Hubert <bert.hubert@netherlabs.nl>
Date: Sun, 2 Jan 2011 21:50:21 +0000 (+0000)
Subject: add some primitive locking to the rrsig cache, plus clarify some logging in the gener... 
X-Git-Tag: auth-3.0~452
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=104f67e9cb5b9e7bec55349a0f8420ac3b482a46;p=pdns

add some primitive locking to the rrsig cache, plus clarify some logging in the generic sql backend


git-svn-id: svn://svn.powerdns.com/pdns/trunk/pdns@1795 d19b8d6e-7fed-0310-83ef-9ca221ded41b
---

diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
index 443525bab..5e5a7ef55 100644
--- a/pdns/backends/gsql/gsqlbackend.cc
+++ b/pdns/backends/gsql/gsqlbackend.cc
@@ -275,7 +275,7 @@ bool GSQLBackend::updateDNSSECOrderAndAuthAbsolute(uint32_t domain_id, const std
 }
 bool GSQLBackend::getBeforeAndAfterNamesAbsolute(uint32_t id, const std::string& qname, std::string& unhashed, std::string& before, std::string& after)
 {
-  cerr<<"gsql before/after called for id="<<id<<", qname="<<qname<<endl;
+  cerr<<"gsql before/after called for id="<<id<<", qname='"<<qname<<"'"<<endl;
   unhashed.clear(); before.clear(); after.clear();
   string lcqname=toLower(qname);
   
diff --git a/pdns/dbdnsseckeeper.cc b/pdns/dbdnsseckeeper.cc
index f09d8ffd6..d952b6441 100644
--- a/pdns/dbdnsseckeeper.cc
+++ b/pdns/dbdnsseckeeper.cc
@@ -271,7 +271,8 @@ void addSignature(const std::string signQName, const std::string& wildcardname,
   toSign.clear();
 }
 
-// XXXX FIXME THINK ABOUT LOCKING HERE
+pthread_mutex_t g_rrsigs_lock = PTHREAD_MUTEX_INITIALIZER;
+
 map<pair<string, uint16_t>, RRSIGRecordContent> g_rrsigs;
 
 void fillOutRRSIG(const std::string& signQName, RRSIGRecordContent& rrc, const std::string& hash, vector<shared_ptr<DNSRecordContent> >& toSign, bool withKSK) 
@@ -281,11 +282,14 @@ void fillOutRRSIG(const std::string& signQName, RRSIGRecordContent& rrc, const s
   DNSKEYRecordContent drc=getDNSKEYFor(rrc.d_signer, withKSK, &rc);
   rrc.d_tag = drc.getTag();
   rrc.d_algorithm = drc.d_algorithm;
-  
-  if(g_rrsigs.count(make_pair(hash, rrc.d_tag))) {
-    // cerr<<"RRSIG cache hit !"<<endl;
-    rrc = g_rrsigs[make_pair(hash, rrc.d_tag)];
-    return;
+
+  {  
+    Lock l(&g_rrsigs_lock);
+    if(g_rrsigs.count(make_pair(hash, rrc.d_tag))) {
+      // cerr<<"RRSIG cache hit !"<<endl;
+      rrc = g_rrsigs[make_pair(hash, rrc.d_tag)];
+      return;
+    }
   }
     
   string realhash=getSHA1HashForRRSET(signQName, rrc, toSign);
@@ -301,6 +305,6 @@ void fillOutRRSIG(const std::string& signQName, RRSIGRecordContent& rrc, const s
   
   rrc.d_signature.assign((char*)signature, sizeof(signature));
   
+  Lock l(&g_rrsigs_lock);
   g_rrsigs[make_pair(hash, rrc.d_tag)] = rrc;
-
 }