From: Neal Norwitz <nnorwitz@gmail.com>
Date: Tue, 23 Oct 2007 05:35:11 +0000 (+0000)
Subject: Backport 58594:
X-Git-Tag: v2.5.2c1~154
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=1046af6f594d79a7447d1410aee206f5d509ccc5;p=python

Backport 58594:
Issue #1307, patch by Derek Shockey.
When "MAIL" is received without args, an exception happens instead of
sending a 501 syntax error response.
---

diff --git a/Lib/smtpd.py b/Lib/smtpd.py
index c656ec7639..4aa34763ec 100755
--- a/Lib/smtpd.py
+++ b/Lib/smtpd.py
@@ -221,7 +221,7 @@ class SMTPChannel(asynchat.async_chat):
 
     def smtp_MAIL(self, arg):
         print >> DEBUGSTREAM, '===> MAIL', arg
-        address = self.__getaddr('FROM:', arg)
+        address = self.__getaddr('FROM:', arg) if arg else None
         if not address:
             self.push('501 Syntax: MAIL FROM:<address>')
             return
diff --git a/Misc/NEWS b/Misc/NEWS
index a3912191d8..4cc936db04 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -32,6 +32,8 @@ Core and builtins
 Library
 -------
 
+- Bug #1307: Fix smtpd so it doesn't raise an exception when there is no arg.
+
 - ctypes will now work correctly on 32-bit systems when Python is
   configured with --with-system-ffi.