From: krakjoe Date: Sat, 16 Nov 2013 21:28:59 +0000 (+0000) Subject: remove more no expression provided messages X-Git-Tag: php-5.6.0alpha1~110^2~279^2~8 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=102e3477d75a83e88aba64f1c22963b7938d427b;p=php remove more no expression provided messages --- diff --git a/phpdbg_break.c b/phpdbg_break.c index 03d87f6e19..a866eb063a 100644 --- a/phpdbg_break.c +++ b/phpdbg_break.c @@ -29,12 +29,10 @@ ZEND_EXTERN_MODULE_GLOBALS(phpdbg); PHPDBG_BREAK(file) /* {{{ */ { switch (param->type) { - case EMPTY_PARAM: - phpdbg_error("No expression provided"); - break; case FILE_PARAM: phpdbg_set_breakpoint_file(param->file.name, param->file.line TSRMLS_CC); break; + default: phpdbg_error("Unsupported parameter type (%s) for function", phpdbg_get_param_type(param TSRMLS_CC)); break; @@ -46,9 +44,6 @@ PHPDBG_BREAK(file) /* {{{ */ PHPDBG_BREAK(method) /* {{{ */ { switch (param->type) { - case EMPTY_PARAM: - phpdbg_error("No expression provided"); - break; case METHOD_PARAM: phpdbg_set_breakpoint_method(param->method.class, param->method.name TSRMLS_CC); break; @@ -64,12 +59,10 @@ PHPDBG_BREAK(method) /* {{{ */ PHPDBG_BREAK(address) /* {{{ */ { switch (param->type) { - case EMPTY_PARAM: - phpdbg_error("No expression provided"); - break; case ADDR_PARAM: phpdbg_set_breakpoint_opline(param->addr TSRMLS_CC); break; + default: phpdbg_error( "Unsupported parameter type (%s) for function", phpdbg_get_param_type(param TSRMLS_CC)); @@ -99,12 +92,10 @@ PHPDBG_BREAK(lineno) /* {{{ */ } switch (param->type) { - case EMPTY_PARAM: - phpdbg_error("No expression provided!"); - break; case NUMERIC_PARAM: phpdbg_set_breakpoint_file(phpdbg_current_file(TSRMLS_C), param->num TSRMLS_CC); break; + default: phpdbg_error( "Unsupported parameter type (%s) for function", phpdbg_get_param_type(param TSRMLS_CC)); @@ -117,12 +108,10 @@ PHPDBG_BREAK(lineno) /* {{{ */ PHPDBG_BREAK(func) /* {{{ */ { switch (param->type) { - case EMPTY_PARAM: - phpdbg_error("No expression provided!"); - break; case STR_PARAM: phpdbg_set_breakpoint_symbol(param->str TSRMLS_CC); break; + default: phpdbg_error("Unsupported parameter type (%s) for function", phpdbg_get_param_type(param TSRMLS_CC)); break;