From: Rich Salz <rsalz@akamai.com>
Date: Sun, 3 May 2015 12:45:27 +0000 (-0400)
Subject: GH271: Warning on </dev/null to CA.pl
X-Git-Tag: OpenSSL_1_1_0-pre1~1200
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0fd75c7e6e8482489135beb3f536546f27f6d0e5;p=openssl

GH271: Warning on </dev/null to CA.pl

If CA.pl is reading from /dev/null, then "chop $FILE" gives a warning.
Sigh.  Have to add "if $FILE".  This just silences a build warning.
Thanks to GitHub user andrejs-igumenovs for help with this.

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/apps/CA.pl.in b/apps/CA.pl.in
index 9d12a8c28f..5c8cdd09f2 100644
--- a/apps/CA.pl.in
+++ b/apps/CA.pl.in
@@ -121,7 +121,7 @@ if ($WHAT eq '-newcert' ) {
     # ask user for existing CA certificate
     print "CA certificate filename (or enter to create)\n";
     $FILE = <STDIN>;
-    chop $FILE;
+    chop $FILE if $FILE;
     if ($FILE) {
         copy_pemfile($FILE,"${CATOP}/private/$CAKEY", "PRIVATE");
         copy_pemfile($FILE,"${CATOP}/$CACERT", "CERTIFICATE");