From: William A. Rowe Jr <wrowe@apache.org>
Date: Fri, 22 May 2015 07:04:44 +0000 (+0000)
Subject: Concur with two proposals, drop any objection to yet a third proposal
X-Git-Tag: 2.4.13~72
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0f57ae21a4236414bcbdbe83728b82b534d0e581;p=apache

Concur with two proposals, drop any objection to yet a third proposal

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1681008 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/STATUS b/STATUS
index c0de968d60..c78839632e 100644
--- a/STATUS
+++ b/STATUS
@@ -111,7 +111,7 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
                   http://svn.apache.org/r1679181
                   http://svn.apache.org/r1679182
      2.4.x patch: trunk works (modulo CHANGES)
-     +1: ylavic, minfrin, jkaluza
+     +1: ylavic, minfrin, jkaluza, wrowe
 
 
 PATCHES PROPOSED TO BACKPORT FROM TRUNK:
@@ -160,7 +160,9 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
      trunk patch: http://svn.apache.org/r1610339
                   http://svn.apache.org/r1621806
      2.4.x patch: http://people.apache.org/~jkaluza/patches/httpd-2.4.x-mod_journald.patch
-     +1: jkaluza
+     +1: jkaluza, wrowe
+     wrowe: approves as experimental, 'with-modules=all' restriction
+            satisfies an concern I'd otherwise have.
 
    * MPMs: Support SO_REUSEPORT to create multiple duplicated listener
            records for scalability (full log in 2.4.x patch).
@@ -183,14 +185,6 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
                   http://svn.apache.org/r1679714
      2.4.x patch: http://people.apache.org/~ylavic/httpd-2.4.x-ap_listeners_buckets-v3.patch
      +1: ylavic, jim
-     wrowe: the statics are not explicitly initialized for clarity
-            ap_log_common is horribly named, perhaps ap_log_mpm_common()?
-     ylavic: v3 with s/ap_log_common/ap_log_mpm_common/ (jim's vote discarded).
-             globals (including statics) not initialized are implicitely initialized to zero
-             per C standard, and go to .bss (zeroed as a whole at load time), whereas the ones
-             explicitly initialized (even to 0 depending on the compiler/flags) go to .data and
-             have each to be set to their init value (which may take some cycles at load time).
-             I personaly don't see explicit initializations to {0} as a win (even for clarity...).
 
   *) http: Make ap_die() robust against any HTTP error code and not modify
      response status (finally logged) when nothing is to be done. PR 56035.