From: Richard Smith <richard-llvm@metafoo.co.uk>
Date: Mon, 24 Jun 2019 05:53:11 +0000 (+0000)
Subject: PR42362: Fix auto deduction of template parameter packs from
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0f0caf1d8363d0265bee6ee5afb3a12370f01c89;p=clang

PR42362: Fix auto deduction of template parameter packs from
type-dependent argument packs.

We need to strip off the PackExpansionExpr to get the real (dependent)
type rather than an opaque DependentTy.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@364165 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Sema/SemaTemplate.cpp b/lib/Sema/SemaTemplate.cpp
index 7b0a3a3e09..49ba771379 100644
--- a/lib/Sema/SemaTemplate.cpp
+++ b/lib/Sema/SemaTemplate.cpp
@@ -6323,9 +6323,12 @@ ExprResult Sema::CheckTemplateArgument(NonTypeTemplateParmDecl *Param,
     // the type is dependent, in order to check the types of non-type template
     // arguments line up properly in partial ordering.
     Optional<unsigned> Depth = Param->getDepth() + 1;
+    Expr *DeductionArg = Arg;
+    if (auto *PE = dyn_cast<PackExpansionExpr>(DeductionArg))
+      DeductionArg = PE->getPattern();
     if (DeduceAutoType(
             Context.getTrivialTypeSourceInfo(ParamType, Param->getLocation()),
-            Arg, ParamType, Depth) == DAR_Failed) {
+            DeductionArg, ParamType, Depth) == DAR_Failed) {
       Diag(Arg->getExprLoc(),
            diag::err_non_type_template_parm_type_deduction_failure)
         << Param->getDeclName() << Param->getType() << Arg->getType()
diff --git a/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp b/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp
index b887c7f47d..d73a88777d 100644
--- a/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp
+++ b/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp
@@ -378,3 +378,18 @@ template <class T> struct M {
   }
 };
 }
+
+namespace PR42362 {
+  template<auto ...A> struct X { struct Y; void f(int...[A]); };
+  template<auto ...A> struct X<A...>::Y {};
+  template<auto ...A> void X<A...>::f(int...[A]) {}
+  void f() { X<1, 2>::Y y; X<1, 2>().f(0, 0); }
+
+  template<typename, auto...> struct Y;
+  template<auto ...A> struct Y<int, A...> {};
+  Y<int, 1, 2, 3> y;
+
+  template<auto (&...F)()> struct Z { struct Q; };
+  template<auto (&...F)()> struct Z<F...>::Q {};
+  Z<f, f, f>::Q q;
+}