From: Todd C. Miller Date: Mon, 22 Mar 2010 12:09:50 +0000 (-0400) Subject: Check preserve_groups and ignore_ticket args with atobool instead X-Git-Tag: SUDO_1_8_0~777 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0ea44bcba117707cdfa52c127448a6f52a2d6a46;p=sudo Check preserve_groups and ignore_ticket args with atobool instead of assuming they are true if present. --- diff --git a/plugins/sudoers/sudoers.c b/plugins/sudoers/sudoers.c index 6a5645fa9..b2862c8f6 100644 --- a/plugins/sudoers/sudoers.c +++ b/plugins/sudoers/sudoers.c @@ -1153,11 +1153,13 @@ deserialize_info(char * const settings[], char * const user_info[]) continue; } if (MATCHES(*cur, "preserve_groups=")) { - SET(flags, MODE_PRESERVE_GROUPS); + if (atobool(*cur + sizeof("preserve_groups=") - 1) == TRUE) + SET(flags, MODE_PRESERVE_GROUPS); continue; } if (MATCHES(*cur, "ignore_ticket=")) { - SET(flags, MODE_IGNORE_TICKET); + if (atobool(*cur + sizeof("ignore_ticket=") - 1) == TRUE) + SET(flags, MODE_IGNORE_TICKET); continue; } if (MATCHES(*cur, "login_class=")) {