From: Heikki Linnakangas Date: Mon, 27 Jul 2015 15:54:09 +0000 (+0300) Subject: Don't assume that PageIsEmpty() returns true on an all-zeros page. X-Git-Tag: REL9_4_5~122 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0e98ad0915ce5a665f39707db7652c67a64b5b22;p=postgresql Don't assume that PageIsEmpty() returns true on an all-zeros page. It does currently, and I don't see us changing that any time soon, but we don't make that assumption anywhere else. Per Tom Lane's suggestion. Backpatch to 9.2, like the previous patch that added this assumption. --- diff --git a/src/backend/access/spgist/spgvacuum.c b/src/backend/access/spgist/spgvacuum.c index 9033a9df35..c0fff4c6b8 100644 --- a/src/backend/access/spgist/spgvacuum.c +++ b/src/backend/access/spgist/spgvacuum.c @@ -652,7 +652,7 @@ spgvacuumpage(spgBulkDeleteState *bds, BlockNumber blkno) */ if (!SpGistBlockIsRoot(blkno)) { - if (PageIsEmpty(page)) + if (PageIsNew(page) || PageIsEmpty(page)) { RecordFreeIndexPage(index, blkno); bds->stats->pages_deleted++;