From: Ted Kremenek <kremenek@apple.com>
Date: Thu, 29 Jul 2010 00:28:33 +0000 (+0000)
Subject: Remove extraneous guards around the call to getConjuredSymbolVal().  These checks... 
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0e82a936389ead8f22077d5b021cab4ab7bd9899;p=clang

Remove extraneous guards around the call to getConjuredSymbolVal().  These checks are already done within getConjuredSymbolVal() itself.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@109707 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Checker/GRExprEngine.cpp b/lib/Checker/GRExprEngine.cpp
index e2d3bd6668..73fc926260 100644
--- a/lib/Checker/GRExprEngine.cpp
+++ b/lib/Checker/GRExprEngine.cpp
@@ -3234,8 +3234,8 @@ void GRExprEngine::VisitBinaryOperator(const BinaryOperator* B,
         // FIXME: Handle structs.
         QualType T = RHS->getType();
 
-        if ((RightV.isUnknown()||!getConstraintManager().canReasonAbout(RightV))
-            && (Loc::IsLocType(T) || (T->isScalarType()&&T->isIntegerType()))) {
+        if (RightV.isUnknown() ||!getConstraintManager().canReasonAbout(RightV))
+        {
           unsigned Count = Builder->getCurrentBlockCount();
           RightV = ValMgr.getConjuredSymbolVal(NULL, B->getRHS(), Count);
         }
@@ -3322,10 +3322,8 @@ void GRExprEngine::VisitBinaryOperator(const BinaryOperator* B,
 
         SVal LHSVal;
 
-        if ((Result.isUnknown() ||
-             !getConstraintManager().canReasonAbout(Result))
-            && (Loc::IsLocType(CTy)
-                || (CTy->isScalarType() && CTy->isIntegerType()))) {
+        if (Result.isUnknown() ||
+            !getConstraintManager().canReasonAbout(Result)) {
 
           unsigned Count = Builder->getCurrentBlockCount();