From: Steph Fox <sfox@php.net>
Date: Sat, 21 Jun 2008 21:37:39 +0000 (+0000)
Subject: - Don't free stuff you still need
X-Git-Tag: php-5.3.0alpha1~675
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0e5b3a35273fd591b573cfec94efe4ad2205bc6e;p=php

- Don't free stuff you still need
---

diff --git a/ext/phar/util.c b/ext/phar/util.c
index 09119f86f0..2f9e9e3df1 100644
--- a/ext/phar/util.c
+++ b/ext/phar/util.c
@@ -746,12 +746,12 @@ phar_entry_data *phar_get_or_create_entry_data(char *fname, int fname_len, char
 		etemp.tar_type = TAR_FILE;
 	}
 	if (FAILURE == zend_hash_add(&phar->manifest, etemp.filename, path_len, (void*)&etemp, sizeof(phar_entry_info), (void **) &entry)) {
-		efree(ret);
 		php_stream_close(etemp.fp);
-		efree(etemp.filename);
 		if (error) {
 			spprintf(error, 0, "phar error: unable to add new entry \"%s\" to phar \"%s\"", etemp.filename, phar->fname);
 		}
+		efree(ret);
+		efree(etemp.filename);
 		return NULL;
 	}