From: Reis Radomil Date: Sun, 22 Apr 2018 04:16:01 +0000 (+0000) Subject: I18N: handler.c: Do not glue translations together X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0e4a8fc352668b0ce070b875817c00d94b60a519;p=neomutt I18N: handler.c: Do not glue translations together Do not use this antipattern: printf(_("some %s sentence."), b ? _("big") : _("small")); as the translation of "big"/"small" and depends on the sentence it is used in. Instead give the translator the complete sentence: if (b) printf(_("some big sentence.")); else printf(_("some small sentence.")); --- diff --git a/handler.c b/handler.c index 78e3c6966..f96adf1c8 100644 --- a/handler.c +++ b/handler.c @@ -63,12 +63,13 @@ static void print_part_line(struct State *s, struct Body *b, int n) state_mark_attach(s); char *charset = mutt_param_get(&b->parameter, "charset"); if (n != 0) - state_printf(s, _("[-- Alternative Type #%d: "), n); + state_printf(s, _("[-- Alternative Type #%d: %s/%s%s%s, Encoding: %s, Size: %s --]\n"), + n, TYPE(b), b->subtype, charset ? "; charset=" : "", + charset ? charset : "", ENCODING(b->encoding), length); else - state_printf(s, _("[-- Type: ")); - state_printf(s, _("%s/%s%s%s, Encoding: %s, Size: %s --]\n"), TYPE(b), - b->subtype, charset ? "; charset=" : "", charset ? charset : "", - ENCODING(b->encoding), length); + state_printf(s, _("[-- Type: %s/%s%s%s, Encoding: %s, Size: %s --]\n"), + TYPE(b), b->subtype, charset ? "; charset=" : "", + charset ? charset : "", ENCODING(b->encoding), length); } static void convert_to_state(iconv_t cd, char *bufi, size_t *l, struct State *s)