From: Walter Dörwald <walter@livinglogic.de>
Date: Wed, 6 Jun 2007 16:55:38 +0000 (+0000)
Subject: Use O_APPEND flag instead of seeking, when append
X-Git-Tag: v3.0a1~823
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0e41148c4bdb3b1af157a9bf55df4bc27474f1e8;p=python

Use O_APPEND flag instead of seeking, when append
mode is specified.
---

diff --git a/Modules/_fileio.c b/Modules/_fileio.c
index 364748adee..660402f0c7 100644
--- a/Modules/_fileio.c
+++ b/Modules/_fileio.c
@@ -230,6 +230,11 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds)
 	flags |= O_BINARY;
 #endif
 
+#ifdef O_APPEND
+	if (append)
+		flags |= O_APPEND;
+#endif
+
 	if (fd >= 0) {
 		self->fd = fd;
 	}
@@ -242,18 +247,6 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds)
 			PyErr_SetFromErrnoWithFilename(PyExc_IOError, name);
 			goto error;
 		}
-		if (append) {
-			int result;
-			Py_BEGIN_ALLOW_THREADS
-			errno = 0;
-			result = lseek(self->fd, 0, SEEK_END);
-			Py_END_ALLOW_THREADS
-			if (result < 0) {
-				close(self->fd);
-				PyErr_SetFromErrnoWithFilename(PyExc_IOError, name);
-				goto error;
-			}
-		}
 	}
 
 	goto done;