From: Raymond Hettinger <python@rcn.com>
Date: Sat, 19 Sep 2015 06:21:33 +0000 (-0600)
Subject: Hoist constant expression out of an inner loop
X-Git-Tag: v3.6.0a1~1516
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0e14e6610b3cf692377996fad569496191a3f731;p=python

Hoist constant expression out of an inner loop
---

diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c
index 087f8e51a5..dbe44e1455 100644
--- a/Modules/_collectionsmodule.c
+++ b/Modules/_collectionsmodule.c
@@ -371,6 +371,7 @@ static PyObject *
 deque_extend(dequeobject *deque, PyObject *iterable)
 {
     PyObject *it, *item;
+    int trim = (deque->maxlen != -1);
 
     /* Handle case where id(deque) == id(iterable) */
     if ((PyObject *)deque == iterable) {
@@ -417,7 +418,8 @@ deque_extend(dequeobject *deque, PyObject *iterable)
         Py_SIZE(deque)++;
         deque->rightindex++;
         deque->rightblock->data[deque->rightindex] = item;
-        deque_trim_left(deque);
+        if (trim)
+            deque_trim_left(deque);
     }
     if (PyErr_Occurred()) {
         Py_DECREF(it);
@@ -434,6 +436,7 @@ static PyObject *
 deque_extendleft(dequeobject *deque, PyObject *iterable)
 {
     PyObject *it, *item;
+    int trim = (deque->maxlen != -1);
 
     /* Handle case where id(deque) == id(iterable) */
     if ((PyObject *)deque == iterable) {
@@ -480,7 +483,8 @@ deque_extendleft(dequeobject *deque, PyObject *iterable)
         Py_SIZE(deque)++;
         deque->leftindex--;
         deque->leftblock->data[deque->leftindex] = item;
-        deque_trim_right(deque);
+        if (trim)
+            deque_trim_right(deque);
     }
     if (PyErr_Occurred()) {
         Py_DECREF(it);