From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 10 Jun 2009 03:44:35 +0000 (+0000)
Subject: Ensure xmlFree(NULL) is a no-op instead of a core dump.  Per report from
X-Git-Tag: REL8_4_RC1~28
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0dcc73fea4a3371272465f418d323dbd45f9faff;p=postgresql

Ensure xmlFree(NULL) is a no-op instead of a core dump.  Per report from
Sergey Burladyan, there are at least some dank corners of libxml2 that
assume this behavior, even though their published documentation suggests
they shouldn't.

This is only really a live problem in 8.3, but the code is still there
for possible debugging use in HEAD, so patch both branches.
---

diff --git a/src/backend/utils/adt/xml.c b/src/backend/utils/adt/xml.c
index fca92e867d..18f209489e 100644
--- a/src/backend/utils/adt/xml.c
+++ b/src/backend/utils/adt/xml.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.90 2009/06/09 22:00:57 petere Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.91 2009/06/10 03:44:35 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1293,7 +1293,9 @@ xml_repalloc(void *ptr, size_t size)
 static void
 xml_pfree(void *ptr)
 {
-	pfree(ptr);
+	/* At least some parts of libxml assume xmlFree(NULL) is allowed */
+	if (ptr)
+		pfree(ptr);
 }