From: Younies Mahmoud <younies.mahmoud@gmail.com>
Date: Sat, 21 Mar 2020 07:17:28 +0000 (+0100)
Subject: use CharString for internal data
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0d76f5ce52a1a6c18acdaa8a690f50a3f890456b;p=icu

use CharString for internal data
---

diff --git a/icu4c/source/i18n/unitconverter.cpp b/icu4c/source/i18n/unitconverter.cpp
index 5d6479ab53f..6f8d5825457 100644
--- a/icu4c/source/i18n/unitconverter.cpp
+++ b/icu4c/source/i18n/unitconverter.cpp
@@ -417,8 +417,8 @@ void loadConversionRate(ConversionRate &conversionRate, StringPiece source, Stri
     // Substitute constants
     substituteConstants(finalFactor, status);
 
-    conversionRate.source = source;
-    conversionRate.target = target;
+    conversionRate.source = CharString(source, status);
+    conversionRate.target = CharString(target, status);
 
     conversionRate.factorNum = finalFactor.factorNum;
     conversionRate.factorDen = finalFactor.factorDen;
diff --git a/icu4c/source/i18n/unitconverter.h b/icu4c/source/i18n/unitconverter.h
index 9b729aef959..d7df63eabd8 100644
--- a/icu4c/source/i18n/unitconverter.h
+++ b/icu4c/source/i18n/unitconverter.h
@@ -19,8 +19,8 @@ U_NAMESPACE_BEGIN
  * Represents the conversion rate between `source` and `target`.
  */
 struct ConversionRate {
-    StringPiece source;
-    StringPiece target;
+    CharString source;
+    CharString target;
     double factorNum = 1;
     double factorDen = 1;
     double sourceOffset = 0;