From: Olaf Faaland <faaland1@llnl.gov>
Date: Thu, 22 Feb 2018 17:14:46 +0000 (-0800)
Subject: Do not initiate MMP writes while pool is suspended
X-Git-Tag: zfs-0.8.0-rc1~315
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0d398b25644ff1eb67141629bc6e5aead95edeba;p=zfs

Do not initiate MMP writes while pool is suspended

While the pool is suspended on host A, it may be imported on host B.
If host A continued to write MMP blocks, it would be blindly
overwriting MMP blocks written by host B, and the blocks written by
host A would have outdated txg information.

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Olaf Faaland <faaland1@llnl.gov>
Closes #7182
---

diff --git a/module/zfs/mmp.c b/module/zfs/mmp.c
index 986e4f7dc..cce6b77ce 100644
--- a/module/zfs/mmp.c
+++ b/module/zfs/mmp.c
@@ -438,7 +438,7 @@ mmp_thread(void *arg)
 			zio_suspend(spa, NULL);
 		}
 
-		if (multihost)
+		if (multihost && !suspended)
 			mmp_write_uberblock(spa);
 
 		CALLB_CPR_SAFE_BEGIN(&cpr);