From: Nick Mathewson <nickm@torproject.org>
Date: Sat, 13 Mar 2010 05:29:15 +0000 (-0500)
Subject: Fix an obnoxious typo in the bufferevent_timeout_filter test
X-Git-Tag: release-2.0.5-beta~91
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0d047c3f11b4639236816c8f7a166e233d88d10c;p=libevent

Fix an obnoxious typo in the bufferevent_timeout_filter test

We were using the same bufferevent as the child of two filtering parents,
orphaning another.  This made one get freed twice, and the other not at all.

Possible fix for bug 2963306 spotted by Doug Cuthbertson.
---

diff --git a/test/regress_bufferevent.c b/test/regress_bufferevent.c
index 7d7014e2..1960077b 100644
--- a/test/regress_bufferevent.c
+++ b/test/regress_bufferevent.c
@@ -682,7 +682,7 @@ test_bufferevent_timeouts(void *arg)
 		struct bufferevent *bevf1, *bevf2;
 		bevf1 = bufferevent_filter_new(bev1, NULL, NULL,
 		    BEV_OPT_CLOSE_ON_FREE, NULL, NULL);
-		bevf2 = bufferevent_filter_new(bev1, NULL, NULL,
+		bevf2 = bufferevent_filter_new(bev2, NULL, NULL,
 		    BEV_OPT_CLOSE_ON_FREE, NULL, NULL);
 		tt_assert(bevf1);
 		tt_assert(bevf2);