From: Evandro Menezes Date: Wed, 9 Oct 2019 22:03:23 +0000 (+0000) Subject: [InstCombine] Fix PR43617 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0cb14ca5d8383fae16e269a2c58cc5bc217248fe;p=llvm [InstCombine] Fix PR43617 Check for `nullptr` before inspecting composite function. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@374243 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Transforms/Utils/SimplifyLibCalls.cpp b/lib/Transforms/Utils/SimplifyLibCalls.cpp index 461a5e2cba0..beb0d307c26 100644 --- a/lib/Transforms/Utils/SimplifyLibCalls.cpp +++ b/lib/Transforms/Utils/SimplifyLibCalls.cpp @@ -1916,10 +1916,10 @@ Value *LibCallSimplifier::optimizeLog(CallInst *Log, IRBuilder<> &B) { B.setFastMathFlags(FastMathFlags::getFast()); Function *ArgFn = Arg->getCalledFunction(); - StringRef ArgNm = ArgFn->getName(); - Intrinsic::ID ArgID = ArgFn->getIntrinsicID(); + Intrinsic::ID ArgID = + ArgFn ? ArgFn->getIntrinsicID() : Intrinsic::not_intrinsic; LibFunc ArgLb = NotLibFunc; - TLI->getLibFunc(ArgNm, ArgLb); + TLI->getLibFunc(Arg, ArgLb); // log(pow(x,y)) -> y*log(x) if (ArgLb == PowLb || ArgID == Intrinsic::pow) { @@ -1934,9 +1934,10 @@ Value *LibCallSimplifier::optimizeLog(CallInst *Log, IRBuilder<> &B) { substituteInParent(Arg, MulY); return MulY; } + // log(exp{,2,10}(y)) -> y*log({e,2,10}) // TODO: There is no exp10() intrinsic yet. - else if (ArgLb == ExpLb || ArgLb == Exp2Lb || ArgLb == Exp10Lb || + if (ArgLb == ExpLb || ArgLb == Exp2Lb || ArgLb == Exp10Lb || ArgID == Intrinsic::exp || ArgID == Intrinsic::exp2) { Constant *Eul; if (ArgLb == ExpLb || ArgID == Intrinsic::exp)