From: Ulf Wendel <uw@php.net>
Date: Mon, 21 Sep 2009 10:16:44 +0000 (+0000)
Subject: Not nice but neither the MySQL Client Library not mysqlnd are supposed to detect... 
X-Git-Tag: php-5.4.0alpha1~191^2~2633
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0c8262069fd4788bafdc752ceb23cddd7df01f4a;p=php

Not nice but neither the MySQL Client Library not mysqlnd are supposed to detect invalid flags. Therefore: fixing test
---

diff --git a/ext/mysqli/tests/mysqli_stmt_attr_set.phpt b/ext/mysqli/tests/mysqli_stmt_attr_set.phpt
index 810f19fdaa..1964fe82d0 100644
--- a/ext/mysqli/tests/mysqli_stmt_attr_set.phpt
+++ b/ext/mysqli/tests/mysqli_stmt_attr_set.phpt
@@ -1,5 +1,5 @@
 --TEST--
-mysqli_stmt_attr_set() - KNOWN ISSUE: mysqlnd does not check for invalid codes
+mysqli_stmt_attr_set() - mysqlnd does not check for invalid codes
 --SKIPIF--
 <?php
 require_once('skipif.inc');
@@ -58,8 +58,9 @@ require_once('skipifconnectfailure.inc');
 		do {
 			$invalid_attr = mt_rand(-1 * PHP_INT_MAX + 1, PHP_INT_MAX);
 		} while (in_array($invalid_attr, $valid_attr));
-		if (false !== ($tmp = @mysqli_stmt_attr_set($stmt, $invalid_attr, 0)))
-			printf("[006b] Expecting boolean/false for attribute %d, got %s/%s\n", $invalid_attr, gettype($tmp), $tmp);
+		if (true !== ($tmp = @mysqli_stmt_attr_set($stmt, $invalid_attr, 0)))
+			/* Although it may be desired to get false neither the MySQL Client Library nor mysqlnd are supposed to detect invalid codes */
+			printf("[006b] Expecting boolean/true for attribute %d, got %s/%s\n", $invalid_attr, gettype($tmp), $tmp);
 	}
 	$stmt->close();