From: Martin v. Löwis <martin@v.loewis.de>
Date: Fri, 23 Mar 2007 13:27:15 +0000 (+0000)
Subject: Bug #978833: Revert r50844, as it broke _socketobject.dup.
X-Git-Tag: v2.6a1~1942
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0af338859b86880cdfe0fe5b3abeea8acace33eb;p=python

Bug #978833: Revert r50844, as it broke _socketobject.dup.
Will backport.
---

diff --git a/Lib/httplib.py b/Lib/httplib.py
index 4797e0317d..213d80c2b4 100644
--- a/Lib/httplib.py
+++ b/Lib/httplib.py
@@ -948,8 +948,8 @@ class HTTPConnection:
         self.__state = _CS_IDLE
 
         if response.will_close:
-            # Pass the socket to the response
-            self.sock = None
+            # this effectively passes the connection to the response
+            self.close()
         else:
             # remember this, so we can tell when it is complete
             self.__response = response
diff --git a/Lib/socket.py b/Lib/socket.py
index b4969bddd0..0082e7656e 100644
--- a/Lib/socket.py
+++ b/Lib/socket.py
@@ -139,8 +139,6 @@ class _closedsocket(object):
     __slots__ = []
     def _dummy(*args):
         raise error(EBADF, 'Bad file descriptor')
-    def close(self):
-        pass
     # All _delegate_methods must also be initialized here.
     send = recv = recv_into = sendto = recvfrom = recvfrom_into = _dummy
     __getattr__ = _dummy
@@ -159,7 +157,6 @@ class _socketobject(object):
             setattr(self, method, getattr(_sock, method))
 
     def close(self):
-        self._sock.close()
         self._sock = _closedsocket()
         dummy = self._sock._dummy
         for method in _delegate_methods:
diff --git a/Misc/NEWS b/Misc/NEWS
index 1f1caee8e7..3489240c8a 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -199,6 +199,8 @@ Core and builtins
 Library
 -------
 
+- Bug #978833: Revert r50844, as it broke _socketobject.dup.
+
 - Bug #1675967: re patterns pickled with Python 2.4 and earlier can
   now be unpickled with Python 2.5 and newer.