From: Malcolm Parsons Date: Tue, 6 Dec 2016 14:49:18 +0000 (+0000) Subject: Fix two clang-tidy misc-move-forwarding-reference warnings X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0a393fab0d71283d9be55dee2d360959f2c1fb15;p=clang Fix two clang-tidy misc-move-forwarding-reference warnings Patch by Michael Sharpe. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@288813 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/AST/Type.cpp b/lib/AST/Type.cpp index d98d8d72ae..0d0cd2e305 100644 --- a/lib/AST/Type.cpp +++ b/lib/AST/Type.cpp @@ -1057,7 +1057,7 @@ QualType simpleTransform(ASTContext &ctx, QualType type, F &&f) { SplitQualType splitType = type.split(); // Visit the type itself. - SimpleTransformVisitor visitor(ctx, std::move(f)); + SimpleTransformVisitor visitor(ctx, std::forward(f)); QualType result = visitor.Visit(splitType.Ty); if (result.isNull()) return result; diff --git a/lib/CodeGen/CGBlocks.cpp b/lib/CodeGen/CGBlocks.cpp index 09911d4b09..50a6d61e7e 100644 --- a/lib/CodeGen/CGBlocks.cpp +++ b/lib/CodeGen/CGBlocks.cpp @@ -1941,7 +1941,7 @@ static T *buildByrefHelpers(CodeGenModule &CGM, const BlockByrefInfo &byrefInfo, generator.CopyHelper = buildByrefCopyHelper(CGM, byrefInfo, generator); generator.DisposeHelper = buildByrefDisposeHelper(CGM, byrefInfo, generator); - T *copy = new (CGM.getContext()) T(std::move(generator)); + T *copy = new (CGM.getContext()) T(std::forward(generator)); CGM.ByrefHelpersCache.InsertNode(copy, insertPos); return copy; }