From: Richard Russon <rich@flatcap.org>
Date: Thu, 13 Dec 2018 20:32:26 +0000 (+0000)
Subject: minor code tidying
X-Git-Tag: 2019-10-25~441
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0a0ead817fd773ec48d385a4d7ec199b1a9f4d3f;p=neomutt

minor code tidying

boolify variables
make function static
fix translation typo
---

diff --git a/mutt_thread.c b/mutt_thread.c
index 9f46b170d..153dc44aa 100644
--- a/mutt_thread.c
+++ b/mutt_thread.c
@@ -73,7 +73,7 @@ static bool is_visible(struct Email *e, struct Context *ctx)
  * @param e Email
  * @retval true If the subject should be displayed
  */
-bool need_display_subject(struct Context *ctx, struct Email *e)
+static bool need_display_subject(struct Context *ctx, struct Email *e)
 {
   struct MuttThread *tmp = NULL, *tree = e->thread;
 
diff --git a/nntp/nntp.c b/nntp/nntp.c
index 8773819b5..688e57813 100644
--- a/nntp/nntp.c
+++ b/nntp/nntp.c
@@ -1475,7 +1475,7 @@ static int nntp_fetch_headers(struct Mailbox *m, void *hc, anum_t first, anum_t
  * @retval  0 No change
  * @retval -1 Lost connection
  */
-static int nntp_group_poll(struct NntpMboxData *mdata, int update_stat)
+static int nntp_group_poll(struct NntpMboxData *mdata, bool update_stat)
 {
   char buf[LONG_STRING] = "";
   anum_t count, first, last;
@@ -1544,7 +1544,7 @@ static int check_mailbox(struct Context *ctx)
     return -1;
 
   adata->check_time = now;
-  rc = nntp_group_poll(mdata, 0);
+  rc = nntp_group_poll(mdata, false);
   if (rc < 0)
   {
     nntp_newsrc_close(adata);
@@ -2133,7 +2133,7 @@ int nntp_check_new_groups(struct Mailbox *m, struct NntpAccountData *adata)
 
       if (mdata && mdata->subscribed)
       {
-        rc = nntp_group_poll(mdata, 1);
+        rc = nntp_group_poll(mdata, true);
         if (rc < 0)
           return -1;
         if (rc > 0)
diff --git a/po/fi.po b/po/fi.po
index 60d7e74c3..d3c3c4d67 100644
--- a/po/fi.po
+++ b/po/fi.po
@@ -598,7 +598,7 @@ msgstr "Bcc: "
 #. L10N: Compose menu field.  May not want to translate.
 #: compose.c:142 compose.c:1042 send.c:387
 msgid "Subject: "
-msgstr "Subjet: "
+msgstr "Subject: "
 
 #. L10N: Compose menu field.  May not want to translate.
 #: compose.c:144
diff --git a/postpone.c b/postpone.c
index 3626e34f6..c4e943a80 100644
--- a/postpone.c
+++ b/postpone.c
@@ -73,7 +73,7 @@ static const struct Mapping PostponeHelp[] = {
 
 static short PostCount = 0;
 static struct Context *PostContext = NULL;
-static short UpdateNumPostponed = 0;
+static bool UpdateNumPostponed = false;
 
 /**
  * mutt_num_postponed - Return the number of postponed messages
@@ -92,7 +92,7 @@ int mutt_num_postponed(struct Mailbox *m, bool force)
 
   if (UpdateNumPostponed)
   {
-    UpdateNumPostponed = 0;
+    UpdateNumPostponed = false;
     force = true;
   }
 
@@ -191,7 +191,7 @@ int mutt_num_postponed(struct Mailbox *m, bool force)
  */
 void mutt_update_num_postponed(void)
 {
-  UpdateNumPostponed = 1;
+  UpdateNumPostponed = true;
 }
 
 /**