From: Dov Grobgeld <dov.grobgeld@gmail.com>
Date: Sun, 22 Jul 2018 18:55:19 +0000 (+0300)
Subject: Remove skipping tests and fixed two test errors.
X-Git-Tag: v1.0.5~3
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0932559b116ec3aa15a483c32845b439535b1fb7;p=fribidi

Remove skipping tests and fixed two test errors.

- BidiCharTest was erroneously skipping RTL tests. This has been
  fixed.
- This exposed 18 errors. Two have been fixed in this commit, but
  16 remains.
---

diff --git a/lib/fribidi-bidi.c b/lib/fribidi-bidi.c
index 9d700d3..4966369 100644
--- a/lib/fribidi-bidi.c
+++ b/lib/fribidi-bidi.c
@@ -1175,7 +1175,7 @@ fribidi_get_par_embedding_levels_ex (
         const FriBidiBracketType NoBracket = FRIBIDI_NO_BRACKET;
         for_run_list (pp, main_run_list)
           pp->bracket_type = NoBracket;
-        compact_list (main_run_list);
+        compact_neutrals (main_run_list);
       }
     }
 
diff --git a/test/unicode-conformance/BidiCharacterTest.c b/test/unicode-conformance/BidiCharacterTest.c
index 791f911..cf3f676 100644
--- a/test/unicode-conformance/BidiCharacterTest.c
+++ b/test/unicode-conformance/BidiCharacterTest.c
@@ -253,7 +253,7 @@ main (int argc, char **argv)
   FriBidiChar *code_points = NULL;
   int code_points_len = 0;
   int expected_ltor_len = 0;
-  int base_dir_mode = 0, paragraph_dir;
+  int paragraph_dir = 0;
   FriBidiLevel *expected_levels = NULL;
   int *expected_ltor = NULL;
   int resolved_paragraph_embedding_level;
@@ -345,9 +345,6 @@ main (int argc, char **argv)
                 bracket_types[i] = NoBracket;
           }
 
-        if ((paragraph_dir & (1<<base_dir_mode)) == 0)
-          continue;
-
         switch (paragraph_dir)
           {
           case 0: base_dir = FRIBIDI_PAR_LTR; break;
@@ -430,17 +427,8 @@ main (int argc, char **argv)
 
             if (debug)
               {
-                FriBidiParType base_dir;
-
                 fribidi_set_debug (1);
 
-                switch (base_dir_mode)
-                  {
-                  case 0: base_dir = FRIBIDI_PAR_ON;  break;
-                  case 1: base_dir = FRIBIDI_PAR_LTR; break;
-                  case 2: base_dir = FRIBIDI_PAR_RTL; break;
-                  }
-
                 if (fribidi_get_par_embedding_levels_ex (types,
                                                          bracket_types,
                                                          types_len,