From: Craig Topper Date: Mon, 27 Feb 2017 06:05:30 +0000 (+0000) Subject: [X86] Check for less than 0 rather than explicit compare with -1. NFC X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=08d480dc7719176d59e2cc4f21b43e02d5a0b997;p=llvm [X86] Check for less than 0 rather than explicit compare with -1. NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@296321 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp index 348f8308099..d27b53abe70 100644 --- a/lib/Target/X86/X86ISelLowering.cpp +++ b/lib/Target/X86/X86ISelLowering.cpp @@ -8141,12 +8141,13 @@ static bool isNonZeroElementsInOrder(const SmallBitVector &Zeroable, // Check if the Mask's nonzero elements are in increasing order. for (int i = 0, e = Zeroable.size(); i < e; i++) { // Checks if the mask's zeros elements are built from only zeros. - if (Mask[i] == -1) + assert(Mask[i] >= -1 && "Out of bound mask element!"); + if (Mask[i] < 0) return false; if (Zeroable[i]) continue; // Find the lowest non zero element - if (NextElement == -1) { + if (NextElement < 0) { NextElement = Mask[i] != 0 ? VectorType.getVectorNumElements() : 0; IsZeroSideLeft = NextElement != 0; }