From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Tue, 23 Jul 2013 21:38:31 +0000 (-0400)
Subject: Check for NULL result from strdup
X-Git-Tag: REL8_4_18~20
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0883c85334f80ff9cc54607aac508618f871c82c;p=postgresql

Check for NULL result from strdup

Per Coverity Scan
---

diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
index f5328e4c94..847f2721dd 100644
--- a/src/interfaces/libpq/fe-secure.c
+++ b/src/interfaces/libpq/fe-secure.c
@@ -875,7 +875,17 @@ client_cert_cb(SSL *ssl, X509 **x509, EVP_PKEY **pkey)
 		{
 			/* Colon, but not in second character, treat as engine:key */
 			char	   *engine_str = strdup(conn->sslkey);
-			char	   *engine_colon = strchr(engine_str, ':');
+			char	   *engine_colon;
+
+			if (engine_str == NULL)
+			{
+				printfPQExpBuffer(&conn->errorMessage,
+								  libpq_gettext("out of memory\n"));
+				return -1;
+			}
+
+			/* cannot return NULL because we already checked before strdup */
+			engine_colon = strchr(engine_str, ':');
 
 			*engine_colon = '\0';		/* engine_str now has engine name */
 			engine_colon++;		/* engine_colon now has key name */