From: Ben Laurie Date: Thu, 21 Feb 2013 18:30:04 +0000 (+0000) Subject: Fix ignored return value warnings. X-Git-Tag: master-pre-reformat~1372 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0850f11855fff2691d5827ea56b4b55307163612;p=openssl Fix ignored return value warnings. Not sure why I am getting these now and not before. --- diff --git a/engines/ccgost/gost2814789t.c b/engines/ccgost/gost2814789t.c index 389ba50370..8b386b4f71 100644 --- a/engines/ccgost/gost2814789t.c +++ b/engines/ccgost/gost2814789t.c @@ -1573,7 +1573,7 @@ engine_cipher_check: (unsigned int)ullLeft); } siglen = 4; - EVP_DigestSignFinal(&mctx, bTest, &siglen); + OPENSSL_assert(EVP_DigestSignFinal(&mctx, bTest, &siglen)); EVP_MD_CTX_cleanup(&mctx); enlu = (int)tcs[t].ullLen; enlf = 0; diff --git a/ssl/s3_cbc.c b/ssl/s3_cbc.c index 1db1d8c32a..87cdc3b244 100644 --- a/ssl/s3_cbc.c +++ b/ssl/s3_cbc.c @@ -462,6 +462,7 @@ void ssl3_cbc_digest_record( * the hash. */ unsigned md_length_size = 8; char length_is_big_endian = 1; + int ret; /* This is a, hopefully redundant, check that allows us to forget about * many possible overflows later in this function. */ @@ -733,8 +734,8 @@ void ssl3_cbc_digest_record( EVP_DigestUpdate(&md_ctx, hmac_pad, md_block_size); EVP_DigestUpdate(&md_ctx, mac_out, md_size); } - EVP_DigestFinal(&md_ctx, md_out, &md_out_size_u); - if (md_out_size) + ret = EVP_DigestFinal(&md_ctx, md_out, &md_out_size_u); + if (ret && md_out_size) *md_out_size = md_out_size_u; EVP_MD_CTX_cleanup(&md_ctx); }