From: Victor Stinner <vstinner@redhat.com>
Date: Mon, 15 Apr 2019 15:54:09 +0000 (+0200)
Subject: bpo-36389: Cleanup gc.set_threshold() (GH-12844)
X-Git-Tag: v3.8.0a4~173
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0810fa79885276114d1a94e2ce61da367ebb1ffc;p=python

bpo-36389: Cleanup gc.set_threshold() (GH-12844)

Don't assign generations[2].threshold to generations[2].threshold:
useless operation.
---

diff --git a/Modules/gcmodule.c b/Modules/gcmodule.c
index fad1356d6b..a75d5fed95 100644
--- a/Modules/gcmodule.c
+++ b/Modules/gcmodule.c
@@ -1374,7 +1374,7 @@ gc_set_thresh(PyObject *self, PyObject *args)
                           &_PyRuntime.gc.generations[1].threshold,
                           &_PyRuntime.gc.generations[2].threshold))
         return NULL;
-    for (i = 2; i < NUM_GENERATIONS; i++) {
+    for (i = 3; i < NUM_GENERATIONS; i++) {
         /* generations higher than 2 get the same threshold */
         _PyRuntime.gc.generations[i].threshold = _PyRuntime.gc.generations[2].threshold;
     }
@@ -1524,7 +1524,7 @@ gc_get_objects_impl(PyObject *module, Py_ssize_t generation)
     }
 
     /* If generation is passed, we extract only that generation */
-    if (generation != -1) { 
+    if (generation != -1) {
         if (generation >= NUM_GENERATIONS) {
             PyErr_Format(PyExc_ValueError,
                          "generation parameter must be less than the number of "