From: Todd C. Miller <Todd.Miller@courtesan.com>
Date: Thu, 24 Oct 2013 16:40:51 +0000 (-0600)
Subject: Add missing else when the connection from the monitor to the parent
X-Git-Tag: SUDO_1_8_9^2~140
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=07e0a068dc5d5d121f6571495392166082773ff9;p=sudo

Add missing else when the connection from the monitor to the parent
sudo process is broken (due to the parent dying).  Prevents a
spurious "unexpected reply type on backchannel" warning.
---

diff --git a/src/exec_pty.c b/src/exec_pty.c
index 8b3599aa6..61ebd805a 100644
--- a/src/exec_pty.c
+++ b/src/exec_pty.c
@@ -1157,11 +1157,12 @@ mon_backchannel_cb(int fd, int what, void *v)
 	    /* short read or EOF, parent process died? */
 	}
 	sudo_ev_loopbreak(mc->evbase);
-    }
-    if (cstmp.type == CMD_SIGNO) {
-	deliver_signal(cmnd_pid, cstmp.val, true);
     } else {
-	warningx(_("unexpected reply type on backchannel: %d"), cstmp.type);
+	if (cstmp.type == CMD_SIGNO) {
+	    deliver_signal(cmnd_pid, cstmp.val, true);
+	} else {
+	    warningx(_("unexpected reply type on backchannel: %d"), cstmp.type);
+	}
     }
     debug_return;
 }