From: Alexey Bataev Date: Tue, 18 Jun 2019 20:29:06 +0000 (+0000) Subject: [OPENMP]Use host's mangling for 128 bit float types on the device. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=07bf9d38a0428948701b09ac21fbba9168ec3f95;p=clang [OPENMP]Use host's mangling for 128 bit float types on the device. Device have to use the same mangling as the host for 128bit float types. Otherwise, the codegen for the device is unable to find the parent function when it tries to generate the outlined function for the target region and it leads to incorrect compilation and crash at the runtime. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@363734 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/AST/ItaniumMangle.cpp b/lib/AST/ItaniumMangle.cpp index 4fe3bfe656..031aac0dbe 100644 --- a/lib/AST/ItaniumMangle.cpp +++ b/lib/AST/ItaniumMangle.cpp @@ -2607,17 +2607,33 @@ void CXXNameMangler::mangleType(const BuiltinType *T) { case BuiltinType::Double: Out << 'd'; break; - case BuiltinType::LongDouble: - Out << (getASTContext().getTargetInfo().useFloat128ManglingForLongDouble() - ? 'g' - : 'e'); + case BuiltinType::LongDouble: { + bool UseFloat128Mangling = + getASTContext().getTargetInfo().useFloat128ManglingForLongDouble(); + if (getASTContext().getLangOpts().OpenMP && + getASTContext().getLangOpts().OpenMPIsDevice) { + UseFloat128Mangling = getASTContext() + .getAuxTargetInfo() + ->useFloat128ManglingForLongDouble(); + } + Out << (UseFloat128Mangling ? 'g' : 'e'); break; - case BuiltinType::Float128: - if (getASTContext().getTargetInfo().useFloat128ManglingForLongDouble()) + } + case BuiltinType::Float128: { + bool UseFloat128Mangling = + getASTContext().getTargetInfo().useFloat128ManglingForLongDouble(); + if (getASTContext().getLangOpts().OpenMP && + getASTContext().getLangOpts().OpenMPIsDevice) { + UseFloat128Mangling = getASTContext() + .getAuxTargetInfo() + ->useFloat128ManglingForLongDouble(); + } + if (UseFloat128Mangling) Out << "U10__float128"; // Match the GCC mangling else Out << 'g'; break; + } case BuiltinType::NullPtr: Out << "Dn"; break; diff --git a/test/OpenMP/nvptx_unsupported_type_codegen.cpp b/test/OpenMP/nvptx_unsupported_type_codegen.cpp index 2573daaa41..81e7df7e35 100644 --- a/test/OpenMP/nvptx_unsupported_type_codegen.cpp +++ b/test/OpenMP/nvptx_unsupported_type_codegen.cpp @@ -8,13 +8,15 @@ // CHECK-DAG: [[T:%.+]] = type {{.+}}, fp128, // CHECK-DAG: [[T1:%.+]] = type {{.+}}, i128, i128, -struct T { - char a; #ifndef _ARCH_PPC - __float128 f; +typedef __float128 BIGTYPE; #else - long double f; +typedef long double BIGTYPE; #endif + +struct T { + char a; + BIGTYPE f; char c; T() : a(12), f(15) {} T &operator+(T &b) { f += b.a; return *this;} @@ -68,3 +70,12 @@ void baz1() { T1 t = bar1(); } #pragma omp end declare target + +BIGTYPE foo(BIGTYPE f) { +#pragma omp target map(f) + f = 1; + return f; +} + +// CHECK: define weak void @__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]* +// CHECK: store [[BIGTYPE]] 0xL00000000000000003FFF000000000000, [[BIGTYPE]]* %