From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Wed, 23 Dec 2015 14:45:46 +0000 (+0100)
Subject: Don't automatically set the QR flag in case of HeaderModify
X-Git-Tag: dnsdist-1.0.0-alpha1~3^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=076d8a4abfd42a7f2aad1303ad0919cd22f16971;p=pdns

Don't automatically set the QR flag in case of HeaderModify

Some actions are actually altering the query and not turning it
into an answer (NoRecurse, DisableValidation).
All the actions that do turn it into an answer are already setting
the QR flag themselves.
---

diff --git a/pdns/dnsdist-tcp.cc b/pdns/dnsdist-tcp.cc
index 51ecb73b2..ee25798cb 100644
--- a/pdns/dnsdist-tcp.cc
+++ b/pdns/dnsdist-tcp.cc
@@ -256,7 +256,6 @@ void* tcpClientThread(int pipefd)
 	case DNSAction::Action::Spoof:
 	  ;
 	case DNSAction::Action::HeaderModify:
-	  dh->qr=true;
 	  break;
 	case DNSAction::Action::Allow:
 	case DNSAction::Action::None:
diff --git a/pdns/dnsdist.cc b/pdns/dnsdist.cc
index 673d7016f..50a3146f2 100644
--- a/pdns/dnsdist.cc
+++ b/pdns/dnsdist.cc
@@ -633,7 +633,6 @@ try
       case DNSAction::Action::Spoof:
 	;
       case DNSAction::Action::HeaderModify:
-	dh->qr=true;
 	break;
       case DNSAction::Action::Delay:
 	delayMsec = static_cast<int>(pdns_stou(ruleresult)); // sorry