From: Craig Small <csmall@enc.com.au>
Date: Sat, 2 Jul 2016 02:25:14 +0000 (+1000)
Subject: kill: report error if cannot kill process
X-Git-Tag: v3.3.12~29
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=07642b8ea6d4d61518808de2e5e7f713a2f36618;p=procps-ng

kill: report error if cannot kill process

Shell kill would report a problem if you tried to kill a process
while procps kill was silent. This meant it looked like kill worked
when it actually failed.

References:
 https://bugs.debian.org/733172
---

diff --git a/NEWS b/NEWS
index d04b42e1..ef62e0f2 100644
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ procps-ng-NEXT
   * ps: Fallback to attr/current for context Debian #786956
   * tests: Conditionally add prctl Debian #816237
   * pidof: check cmd if space in argv0. GitLab #4
+  * kill: report error if cannot kill process #733172
 
 procps-ng-3.3.11
 ----------------
diff --git a/skill.c b/skill.c
index 91475275..53be72dd 100644
--- a/skill.c
+++ b/skill.c
@@ -500,6 +500,7 @@ static void __attribute__ ((__noreturn__))
 		pid = strtol_or_err(argv[i], _("failed to parse argument"));
 		if (!kill((pid_t) pid, signo))
 			continue;
+        error(0, errno, "(%d)", pid);
 		exitvalue = EXIT_FAILURE;
 		continue;
 	}