From: Simon Riggs <simon@2ndQuadrant.com>
Date: Wed, 8 Aug 2012 20:07:35 +0000 (+0100)
Subject: fsync backup_label after pg_start_backup()
X-Git-Tag: REL8_3_20~6
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=074bef820735bcd3b7da9e5d8997e013e6115920;p=postgresql

fsync backup_label after pg_start_backup()

Dave Kerr, backpatched by Simon Riggs
---

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 47d11b945b..88f2b39443 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -6634,7 +6634,7 @@ pg_start_backup(PG_FUNCTION_ARGS)
 				checkpointloc.xlogid, checkpointloc.xrecoff);
 		fprintf(fp, "START TIME: %s\n", strfbuf);
 		fprintf(fp, "LABEL: %s\n", backupidstr);
-		if (fflush(fp) || ferror(fp) || FreeFile(fp))
+		if (fflush(fp) || ferror(fp) || pg_fsync(fileno(fp)) != 0 || FreeFile(fp))
 			ereport(ERROR,
 					(errcode_for_file_access(),
 					 errmsg("could not write file \"%s\": %m",