From: Benjamin Kramer <benny.kra@googlemail.com>
Date: Wed, 18 Oct 2017 21:43:42 +0000 (+0000)
Subject: [Driver] Fix use after free in Hexagon toolchain code.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=070fec4a8362bfce136b8cd82a3977183b2394ee;p=clang

[Driver] Fix use after free in Hexagon toolchain code.

No functionality change intended.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@316127 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Driver/ToolChains/Hexagon.cpp b/lib/Driver/ToolChains/Hexagon.cpp
index ea100fbcce..d4ab5dc5b7 100644
--- a/lib/Driver/ToolChains/Hexagon.cpp
+++ b/lib/Driver/ToolChains/Hexagon.cpp
@@ -28,8 +28,8 @@ using namespace clang;
 using namespace llvm::opt;
 
 // Default hvx-length for various versions.
-static std::string getDefaultHvxLength(const StringRef &Cpu) {
-  return llvm::StringSwitch<std::string>(Cpu)
+static StringRef getDefaultHvxLength(StringRef Cpu) {
+  return llvm::StringSwitch<StringRef>(Cpu)
       .Case("v60", "64b")
       .Case("v62", "64b")
       .Default("128b");
@@ -93,7 +93,7 @@ static void handleHVXTargetFeatures(const Driver &D, const ArgList &Args,
   }
   // Default hvx-length based on Cpu.
   else if (HasHVX)
-    HVXLength = StringRef(getDefaultHvxLength(Cpu));
+    HVXLength = getDefaultHvxLength(Cpu);
 
   if (!HVXLength.empty()) {
     HVXFeature =