From: Alexander Belopolsky <alexander.belopolsky@gmail.com>
Date: Wed, 6 Apr 2011 02:12:22 +0000 (-0400)
Subject: Issue #11576: Fixed timedelta subtraction glitch on big timedelta values
X-Git-Tag: v2.7.2rc1~183^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=07019bcaab87114bc2312f2b916f929c99f3c48b;p=python

Issue #11576: Fixed timedelta subtraction glitch on big timedelta values
---

diff --git a/Lib/test/test_datetime.py b/Lib/test/test_datetime.py
index 1a86353076..d246d60797 100644
--- a/Lib/test/test_datetime.py
+++ b/Lib/test/test_datetime.py
@@ -231,6 +231,13 @@ class TestTimeDelta(HarmlessMixedComparison, unittest.TestCase):
         eq(a//10, td(0, 7*24*360))
         eq(a//3600000, td(0, 0, 7*24*1000))
 
+        # Issue #11576
+        eq(td(999999999, 86399, 999999) - td(999999999, 86399, 999998),
+           td(0, 0, 1))
+        eq(td(999999999, 1, 1) - td(999999999, 1, 0),
+           td(0, 0, 1))
+
+
     def test_disallowed_computations(self):
         a = timedelta(42)
 
diff --git a/Modules/datetimemodule.c b/Modules/datetimemodule.c
index f907093015..f733fa1900 100644
--- a/Modules/datetimemodule.c
+++ b/Modules/datetimemodule.c
@@ -1737,13 +1737,14 @@ delta_subtract(PyObject *left, PyObject *right)
 
     if (PyDelta_Check(left) && PyDelta_Check(right)) {
         /* delta - delta */
-        PyObject *minus_right = PyNumber_Negative(right);
-        if (minus_right) {
-            result = delta_add(left, minus_right);
-            Py_DECREF(minus_right);
-        }
-        else
-            result = NULL;
+        /* The C-level additions can't overflow because of the
+         * invariant bounds.
+         */
+        int days = GET_TD_DAYS(left) - GET_TD_DAYS(right);
+        int seconds = GET_TD_SECONDS(left) - GET_TD_SECONDS(right);
+        int microseconds = GET_TD_MICROSECONDS(left) -
+                           GET_TD_MICROSECONDS(right);
+        result = new_delta(days, seconds, microseconds, 1);
     }
 
     if (result == Py_NotImplemented)