From: Shlomi Fish <shlomif@shlomifish.org>
Date: Thu, 10 Mar 2022 06:55:04 +0000 (+0200)
Subject: Refactoring / code cleanup.
X-Git-Tag: fortune-mod-3.14.0~21
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=06d4b337565a043816dc736bc768a38a7cbdc23c;p=fortune-mod

Refactoring / code cleanup.

See:

* https://en.wikipedia.org/wiki/Code_refactoring

* https://www.refactoring.com/

* https://www.joelonsoftware.com/2002/01/23/rub-a-dub-dub/

Some small optimisations may have slipped in as well.
---

diff --git a/fortune-mod/datfiles/data/rules-of-acquisition-gen.sh b/fortune-mod/datfiles/data/rules-of-acquisition-gen.sh
index 37543a9..c262337 100644
--- a/fortune-mod/datfiles/data/rules-of-acquisition-gen.sh
+++ b/fortune-mod/datfiles/data/rules-of-acquisition-gen.sh
@@ -16,15 +16,15 @@ footer_template="%%"
 line_maxlen=78
 
 # Check command line
-if [ $# -ne 2 ]
-then
-	echo "Usage: ${0##*/} INFILE OUTFILE"
-	exit 2
-fi
 infile="$1"
 shift
 outfile="$1"
 shift
+if test "$#" -ne 0
+then
+	echo "Usage: $0 INFILE OUTFILE"
+	exit 2
+fi
 
 # Convert CSV to DAT + wrap long lines + remove trailing whitespace
 while IFS="${csv_delimiter}" read -r number rule source