From: Ilia Alshanetsky <iliaa@php.net>
Date: Tue, 1 Aug 2006 15:06:12 +0000 (+0000)
Subject: MFB: Fixed memory leak on unused bound name parameters.
X-Git-Tag: RELEASE_1_0_0RC1~2149
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=06bc5e1b467b763805d28b86fc86ab6725061cde;p=php

MFB: Fixed memory leak on unused bound name parameters.
---

diff --git a/ext/pdo/pdo_stmt.c b/ext/pdo/pdo_stmt.c
index 46d02b108e..430bde1af0 100755
--- a/ext/pdo/pdo_stmt.c
+++ b/ext/pdo/pdo_stmt.c
@@ -1452,7 +1452,11 @@ static int register_bound_param(INTERNAL_FUNCTION_PARAMETERS, pdo_stmt_t *stmt,
 	}
 
 	ZVAL_ADDREF(param.parameter);
-	return really_register_bound_param(&param, stmt, is_param TSRMLS_CC);
+	if (!really_register_bound_param(&param, stmt, is_param TSRMLS_CC)) {
+		zval_ptr_dtor(&(param.parameter));
+		return 0;
+	}
+	return 1;
 } /* }}} */
 
 /* {{{ proto bool PDOStatement::bindValue(mixed $paramno, mixed $param [, int $type ])
@@ -1481,7 +1485,11 @@ static PHP_METHOD(PDOStatement, bindValue)
 	}
 	
 	ZVAL_ADDREF(param.parameter);
-	RETURN_BOOL(really_register_bound_param(&param, stmt, TRUE TSRMLS_CC));
+	if (!really_register_bound_param(&param, stmt, TRUE TSRMLS_CC)) {
+		zval_ptr_dtor(&(param.parameter));
+		RETURN_FALSE;
+	}
+	RETURN_TRUE;
 }
 /* }}} */