From: Ethan Furman <ethan@stoneleaf.us>
Date: Sun, 11 Sep 2016 20:25:26 +0000 (-0700)
Subject: Enum._convert: sort by value, then by name
X-Git-Tag: v3.6.0b1~32
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=06339e7493bc696b7b9213437ce0182048b37bab;p=python

Enum._convert: sort by value, then by name
---

diff --git a/Lib/enum.py b/Lib/enum.py
index 1f8766479e..d8303204ee 100644
--- a/Lib/enum.py
+++ b/Lib/enum.py
@@ -616,9 +616,16 @@ class Enum(metaclass=EnumMeta):
         # for a consistent reverse mapping of number to name when there
         # are multiple names for the same number rather than varying
         # between runs due to hash randomization of the module dictionary.
-        members = OrderedDict((name, source[name])
-                              for name in sorted(source.keys())
-                              if filter(name))
+        members = [
+                (name, source[name])
+                for name in source.keys()
+                if filter(name)]
+        try:
+            # sort by value
+            members.sort(key=lambda t: (t[1], t[0]))
+        except TypeError:
+            # unless some values aren't comparable, in which case sort by name
+            members.sort(key=lambda t: t[0])
         cls = cls(name, members, module=module)
         cls.__reduce_ex__ = _reduce_ex_by_name
         module_globals.update(cls.__members__)