From: Anna Zaks Date: Fri, 15 Mar 2013 23:34:31 +0000 (+0000) Subject: [analyzer] Address a TODO in the StreamChecker; otherwise the output is non-determini... X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=0621c45dcd4c5f43df0de5a2febae525d3287b74;p=clang [analyzer] Address a TODO in the StreamChecker; otherwise the output is non-deterministic. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@177207 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/StaticAnalyzer/Checkers/StreamChecker.cpp b/lib/StaticAnalyzer/Checkers/StreamChecker.cpp index 1c38ab0b18..ffdf2d54b4 100644 --- a/lib/StaticAnalyzer/Checkers/StreamChecker.cpp +++ b/lib/StaticAnalyzer/Checkers/StreamChecker.cpp @@ -400,9 +400,8 @@ void StreamChecker::checkDeadSymbols(SymbolReaper &SymReaper, SymbolRef Sym = *I; ProgramStateRef state = C.getState(); const StreamState *SS = state->get(Sym); - // TODO: Shouldn't we have a continue here? if (!SS) - return; + continue; if (SS->isOpened()) { ExplodedNode *N = C.generateSink();