From: Jeff King Date: Mon, 25 Apr 2016 21:15:23 +0000 (-0400) Subject: remote.c: spell __attribute__ correctly X-Git-Tag: v2.8.3~8^2 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=060e7766ba34dc4fef351494239235ba365edd18;p=git remote.c: spell __attribute__ correctly We want to tell the compiler that error_buf() uses printf()-style arguments via the __attribute__ mechanism, but the original commit (3a429d0), forgot the trailing "__". This happens to work with real GNUC-compatible compilers like gcc and clang, but confuses our fallback macro in git-compat-util.h, which only matches the official name (and thus the build fails on compilers like Visual Studio). Reported-by: Philip Oakley Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/remote.c b/remote.c index a467d4ff07..6f4adac558 100644 --- a/remote.c +++ b/remote.c @@ -1705,7 +1705,7 @@ int branch_merge_matches(struct branch *branch, return refname_match(branch->merge[i]->src, refname); } -__attribute((format (printf,2,3))) +__attribute__((format (printf,2,3))) static const char *error_buf(struct strbuf *err, const char *fmt, ...) { if (err) {