From: Brendan Cully <brendan@kublai.com>
Date: Sat, 8 Jul 2017 23:35:08 +0000 (-0700)
Subject: fix signed/unsigned comparison in longest_common_prefix
X-Git-Tag: mutt-1-9-rel~37
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=05dcbcf4cd5597ec5bd2df4f48bbc46896b496a8;p=mutt

fix signed/unsigned comparison in longest_common_prefix
---

diff --git a/imap/imap.c b/imap/imap.c
index a3b9e1e5..2c5d4c63 100644
--- a/imap/imap.c
+++ b/imap/imap.c
@@ -1950,10 +1950,10 @@ int imap_subscribe (char *path, int subscribe)
 
 /* trim dest to the length of the longest prefix it shares with src,
  * returning the length of the trimmed string */
-static int
-longest_common_prefix (char *dest, const char* src, int start, size_t dlen)
+static size_t
+longest_common_prefix (char *dest, const char* src, size_t start, size_t dlen)
 {
-  int pos = start;
+  size_t pos = start;
 
   while (pos < dlen && dest[pos] && dest[pos] == src[pos])
     pos++;
@@ -1970,7 +1970,7 @@ imap_complete_hosts (char *dest, size_t len)
   BUFFY* mailbox;
   CONNECTION* conn;
   int rc = -1;
-  int matchlen;
+  size_t matchlen;
 
   matchlen = mutt_strlen (dest);
   for (mailbox = Incoming; mailbox; mailbox = mailbox->next)
@@ -2023,7 +2023,8 @@ int imap_complete(char* dest, size_t dlen, char* path) {
   char buf[LONG_STRING];
   IMAP_LIST listresp;
   char completion[LONG_STRING];
-  int clen, matchlen = 0;
+  int clen;
+  size_t matchlen = 0;
   int completions = 0;
   IMAP_MBOX mx;
   int rc;