From: PatR <rankin@nethack.org>
Date: Fri, 8 Jan 2021 21:57:52 +0000 (-0800)
Subject: curses: fix unused label 'bail'
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=05c7a21756a4c6bacd2a06840827fcf1fa4bafd6;p=nethack

curses: fix unused label 'bail'

when SELECTSAVED isn't defined by using a goto for it even when
an 'if' was easily avoiding the need for that.
---

diff --git a/win/curses/cursmain.c b/win/curses/cursmain.c
index 5607897ba..7d8d4ac11 100644
--- a/win/curses/cursmain.c
+++ b/win/curses/cursmain.c
@@ -254,10 +254,11 @@ curses_askname()
 
     curses_line_input_dialog("Who are you?", g.plname, PL_NSIZ);
     (void) mungspaces(g.plname);
-    if (g.plname[0] && g.plname[0] != '\033') {
-         iflags.renameallowed = TRUE; /* tty uses this, we don't [yet?] */
-         return;
-    }
+    if (!g.plname[0] || g.plname[0] == '\033')
+         goto bail;
+
+    iflags.renameallowed = TRUE; /* tty uses this, we don't [yet?] */
+    return;
 
  bail:
     /* message is delivered via raw_print() */