From: Chris Lattner Date: Tue, 21 Aug 2007 05:54:53 +0000 (+0000) Subject: update some comments. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=05ba49cc452ff05f7f65ac0919afbfd85232017a;p=clang update some comments. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@41218 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/CodeGen/CGAggExpr.cpp b/CodeGen/CGAggExpr.cpp index 84a69b1d8c..93f78a42ce 100644 --- a/CodeGen/CGAggExpr.cpp +++ b/CodeGen/CGAggExpr.cpp @@ -34,8 +34,6 @@ public: : CGF(cgf), DestPtr(destPtr), VolatileDest(volatileDest) { } - typedef std::pair ComplexPairTy; - //===--------------------------------------------------------------------===// // Utilities //===--------------------------------------------------------------------===// @@ -163,6 +161,7 @@ void CodeGenFunction::EmitAggExpr(const Expr *E, llvm::Value *DestPtr, void CodeGenFunction::EmitAggregateCopy(llvm::Value *DestPtr, llvm::Value *SrcPtr, QualType Ty) { // Don't use memcpy for complex numbers. + // FIXME: split complex number handling out of here. if (Ty->isComplexType()) { llvm::Value *Real, *Imag; EmitLoadOfComplex(SrcPtr, Real, Imag); diff --git a/CodeGen/CGComplexExpr.cpp b/CodeGen/CGComplexExpr.cpp index 719e22a234..a6e6c062e0 100644 --- a/CodeGen/CGComplexExpr.cpp +++ b/CodeGen/CGComplexExpr.cpp @@ -21,7 +21,7 @@ using namespace clang; using namespace CodeGen; //===----------------------------------------------------------------------===// -// Aggregate Expression Emitter +// Complex Expression Emitter //===----------------------------------------------------------------------===// typedef std::pair ComplexPairTy; @@ -99,7 +99,7 @@ ComplexPairTy ComplexExprEmitter::EmitLoadOfLValue(const Expr *E) { //===----------------------------------------------------------------------===// ComplexPairTy ComplexExprEmitter::VisitBinaryOperator(const BinaryOperator *E) { - fprintf(stderr, "Unimplemented aggregate binary expr!\n"); + fprintf(stderr, "Unimplemented complex binary expr!\n"); E->dump(); return ComplexPairTy(); #if 0 @@ -269,7 +269,7 @@ VisitConditionalOperator(const ConditionalOperator *E) { CGF.EmitBlock(LHSBlock); // Handle the GNU extension for missing LHS. - assert(E->getLHS() && "Must have LHS for aggregate value"); + assert(E->getLHS() && "Must have LHS for complex value"); ComplexPairTy LHS = Visit(E->getLHS()); CGF.Builder.CreateBr(ContBlock);