From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Tue, 16 Nov 2021 01:20:45 +0000 (-0800)
Subject: fail deployment if a release exceeds 50 artifacts
X-Git-Tag: 2.50.0~23^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=05a5cb89a22200943e7a16045204d62f71c90572;p=graphviz

fail deployment if a release exceeds 50 artifacts

Following commit 0155cabbb7b22494b3d5da1425059387d8236cf2, the number of
artifacts produced during packaging is down to 40. We expect this count to rise
as the CMake build system continues to be worked on, operating systems move in
and out of support cycles, and the Cygwin/Msys builds are tweaked. This change
introduced a safe guard to fail deployment if the number of artifacts grows to
exceed 50 again.

Related to #2147.
---

diff --git a/ci/deploy.py b/ci/deploy.py
index ef8378355..8e0d4f500 100644
--- a/ci/deploy.py
+++ b/ci/deploy.py
@@ -195,6 +195,12 @@ def main(args: List[str]) -> int: # pylint: disable=missing-function-docstring
         for c in checksum(path):
           assets.append(upload(package_version, c, str(c)[len("Packages/"):]))
 
+  # various release pages truncate the viewable artifacts to 100 or even 50
+  if not options.force and len(assets) > 50:
+    log.error(f"upload has {len(assets)} assets, which will result in some of "
+              "them being unviewable in web page lists")
+    return -1
+
   # we only create Gitlab releases for stable version numbers
   if not options.force:
     if re.match(r"\d+\.\d+\.\d+$", options.version) is None: